Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added exception handler function #8266

Closed
wants to merge 2 commits into from
Closed

Added exception handler function #8266

wants to merge 2 commits into from

Conversation

keshavdalmia10
Copy link
Contributor

Description

Added exception handler function onError in IAlgorithm interface

Related Issue

#8239

Motivation and Context

Now even if there is an runtime error in the algorithm, we can open and close the positions

Requires Documentation Change

How Has This Been Tested?

Tested by running a demo algorithm with a runtime error. The program executes the end_of_algorithm method now

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change which improves implementation)
  • Performance (non-breaking change which improves performance. Please add associated performance test and results)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Non-functional change (xml comments/documentation/etc)

Checklist:

  • My code follows the code style of this project.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My branch follows the naming convention bug-<issue#>-<description> or feature-<issue#>-<description>

@keshavdalmia10
Copy link
Contributor Author

Hi @Martin-Molinero, i have raised the pull request. Please review it.

@AlexCatarino AlexCatarino mentioned this pull request Aug 23, 2024
Open
4 tasks
@Chocksy Chocksy mentioned this pull request Aug 26, 2024
Open
@keshavdalmia10
Copy link
Contributor Author

Hi @Martin-Molinero, can you please help me with this pull request?

@Chocksy
Copy link

Chocksy commented Sep 2, 2024

@keshavdalmia10 do you think you will be able to add tests for this? :D

@keshavdalmia10
Copy link
Contributor Author

@keshavdalmia10 do you think you will be able to add tests for this? :D

Had tried, but could not figure out

@Martin-Molinero
Copy link
Member

Thank you for the contribution @keshavdalmia10!
Sorry but this is not a good first issue really, it's a feature which requires a higher degree of depth in the implementation. Please take a look at existing "good first issue" labeled issues instead

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@keshavdalmia10 @Chocksy @Martin-Molinero